fix: propagate evaluated plans limit and paths limit to the native query planner

[goto-bus-stop]

The experimental max_evaluated_plans and paths_limit options were only propagated to the legacy JS planner, not the native query planner.

Now they work with both planners.

It would be nice to write an integration test. Perhaps by running a query from the apollo-federation test suite and then asserting on the metric value?

---

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

• Changes are compatible¹
• Documentation² completed
• Performance impact assessed and acceptable
• Tests added and passing³
  • Unit Tests
  • Integration Tests
  • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩

2. Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩

3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩

[svc-apollo-docs]

✅ Docs Preview Ready

No new or changed pages found.

[github-actions]

@goto-bus-stop, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

[router-perf]

CI performance tests

• connectors-const - Connectors stress test that runs with a constant number of users
• const - Basic stress test that runs with a constant number of users
• demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
• demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
• enhanced-signature - Enhanced signature enabled
• events - Stress test for events with a lot of users and deduplication ENABLED
• events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
• events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
• events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
• events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
• events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
• extended-reference-mode - Extended reference mode enabled
• large-request - Stress test with a 1 MB request payload
• no-tracing - Basic stress test, no tracing
• reload - Reload test over a long period of time at a constant rate of users
• step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
• step-local-metrics - Field stats that are generated from the router rather than FTV1
• step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
• step - Basic stress test that steps up the number of users over time
• xlarge-request - Stress test with 10 MB request payload
• xxlarge-request - Stress test with 100 MB request payload

[dariuszkuc]

we probably should also pass this down (link)?

[goto-bus-stop]

there is no router config to enable this option as far as i know. my general feeling is that the option could be removed entirely from the query planner, but 🤷🏻‍♀️

[dariuszkuc]

Hmm it is something that we do support in the gateway (which I believe was done as an experimental feature to skip the expensive QP computation) - I'll open a ticket to figure out what we want to do on RS side of things

[goto-bus-stop]

Wait. Why are there two QP configurations?

router/apollo-router/src/configuration/mod.rs

Lines 416 to 430 in dc0426c

	pub(crate) fn rust_query_planner_config(
	&self,
	) -> apollo_federation::query_plan::query_planner::QueryPlannerConfig {
	apollo_federation::query_plan::query_planner::QueryPlannerConfig {
	reuse_query_fragments: self.supergraph.reuse_query_fragments.unwrap_or(true),
	subgraph_graphql_validation: false,
	generate_query_fragments: self.supergraph.generate_query_fragments,
	incremental_delivery:
	apollo_federation::query_plan::query_planner::QueryPlanIncrementalDeliveryConfig {
	enable_defer: self.supergraph.defer_support,
	},
	type_conditioned_fetching: self.experimental_type_conditioned_fetching,
	debug: Default::default(),
	}
	}

router/apollo-router/src/query_planner/bridge_query_planner.rs

Lines 169 to 182 in dc0426c

	let config = apollo_federation::query_plan::query_planner::QueryPlannerConfig {
	reuse_query_fragments: configuration
	.supergraph
	.reuse_query_fragments
	.unwrap_or(true),
	subgraph_graphql_validation: false,
	generate_query_fragments: configuration.supergraph.generate_query_fragments,
	incremental_delivery:
	apollo_federation::query_plan::query_planner::QueryPlanIncrementalDeliveryConfig {
	enable_defer: configuration.supergraph.defer_support,
	},
	type_conditioned_fetching: configuration.experimental_type_conditioned_fetching,
	debug: Default::default(),
	};