Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(federation): clarify TODO comment that we will keep for query planning GA #6099

Merged
merged 2 commits into from
Oct 1, 2024
Merged

chore(federation): clarify TODO comment that we will keep for query planning GA #6099

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d97fb7f
chore(federation): clarify TODO comment that we will keep for query p…
goto-bus-stop Oct 1, 2024
59cf2fd
fmt :skull:
goto-bus-stop Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions apollo-federation/src/schema/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,13 +275,12 @@ impl ValidFederationSchema {
return Ok(name);
}

// TODO: this otherwise needs to check for a type name in schema based
// TODO for composition: this otherwise needs to check for a type name in schema based
// on the latest federation version.
// FED-311
Err(SingleFederationError::Internal {
message: String::from("typename should have been looked in a federation feature"),
}
.into())
// This code path is not hit during planning.
Err(FederationError::internal(
"typename should have been looked in a federation feature",
))
}

pub(crate) fn is_interface_object_type(
Expand Down
Loading