Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generate_query_fragments configuration option #4885

Merged

Conversation

trevor-scheer
Copy link
Member

@trevor-scheer trevor-scheer commented Mar 28, 2024

Closing the loop on apollographql/federation#2958

  • I'm unsure if override + log warning is the appropriate action, do we have a similar pattern in config elsewhere?
  • Is there a place where the yaml config options are all documented? I don't see anything existing for reuse_query_fragments.
  • How to test the log warning was emitted?

@router-perf
Copy link

router-perf bot commented Mar 28, 2024

CI performance tests

  • reload - Reload test over a long period of time at a constant rate of users
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • large-request - Stress test with a 1 MB request payload
  • const - Basic stress test that runs with a constant number of users
  • no-graphos - Basic stress test, no GraphOS.
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • xlarge-request - Stress test with 10 MB request payload
  • step - Basic stress test that steps up the number of users over time

@BrynCooke
Copy link
Contributor

Looks like documentation still needs updating.

@trevor-scheer trevor-scheer requested a review from a team as a code owner March 29, 2024 17:27
@trevor-scheer
Copy link
Member Author

@BrynCooke I added some docs for the new option as well as the existing option since they're pretty related. Let me know if you have any opinions on where the new section belongs, if you think it should go somewhere that isn't where I put it.

apollo-router/src/configuration/mod.rs Outdated Show resolved Hide resolved
@Geal
Copy link
Contributor

Geal commented Apr 2, 2024

the failing integration tests could be due to a cache key changing with the option https://app.circleci.com/pipelines/github/apollographql/router/20059/workflows/bf8a774f-1e0d-49eb-a5ec-4324d6ac90f0/jobs/134413

apollo-router/src/configuration/mod.rs Outdated Show resolved Hide resolved
@trevor-scheer trevor-scheer requested a review from BrynCooke April 3, 2024 00:02
apollo-router/src/configuration/mod.rs Outdated Show resolved Hide resolved
apollo-router/tests/integration/mod.rs Outdated Show resolved Hide resolved
@nicholascioli nicholascioli enabled auto-merge (squash) April 4, 2024 19:10
@nicholascioli nicholascioli merged commit f1d7c8a into apollographql:dev Apr 5, 2024
12 of 13 checks passed
@trevor-scheer
Copy link
Member Author

Thank you both!

@trevor-scheer trevor-scheer deleted the trevor/generate_query_fragments branch April 10, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants