-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reuse cached query plans across schema updates if possible #4883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
CI performance tests
|
we needed to make that change at some point, and since we have to use Parser::parse_field_set which return types at the executable level instead of the AST level, it will simplify the implementation
Geal
changed the title
take the key and requires into account in the schema hash
reuse cached query plans across schema updates if possible
Apr 3, 2024
bnjjj
approved these changes
Apr 3, 2024
feedback from @bnjjj off band: we should make it available via an option, so users can roll it back if we find an issue |
Geal
force-pushed
the
geal/schema-hash-requires
branch
from
April 3, 2024 16:07
2c4c3e2
to
789c8b2
Compare
Merged
This was referenced Apr 23, 2024
abernix
pushed a commit
that referenced
this pull request
Apr 25, 2024
Fix #5006 in #4883 we introduced a query hashing scheme that stays stable across schema updates if the update does not affect the query. Unfortunately, it was not taking introspection queries into account. This fixes the hashing mechanism to add the schema string to hashed data if we encounter an introspection field. This is a temporary fix until we move introspection execution out of query planning. At that point, this hashing mechanism won't ever see introspection fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4834
This extends the schema aware hashing already used for subgraph queries in entity caching, to be usable for client queries, and use that hash in the query planner cache to be able to reuse cached entries across schema reloads.
This contains:
ExecutableDocument
(necessary to parse field sets inkey
andrequires
argument@join__type
'skey
argument and@join__field
'srequires
argument, because they can be affected by schema updates_entities
operationChecklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩