-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move batch query cancellation up #4859
Merged
nicholascioli
merged 6 commits into
garypen/2002-subgraph-batching
from
nc/subgraph-batching/single-cancel-spot
Mar 27, 2024
Merged
Move batch query cancellation up #4859
nicholascioli
merged 6 commits into
garypen/2002-subgraph-batching
from
nc/subgraph-batching/single-cancel-spot
Mar 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI performance tests
|
garypen
approved these changes
Mar 27, 2024
This commit moves handling of cancelled batch queries into the router service so that any custom rust plugin, rhai script, coprocessor, etc. will have cancelled requests handled without needing to handle batches specially.
These tweaks are enough (I think) for us to make progress. Let's review together and then decide how to proceed.
nicholascioli
force-pushed
the
nc/subgraph-batching/single-cancel-spot
branch
from
March 27, 2024 16:56
7e7e01a
to
6c057ab
Compare
garypen
approved these changes
Mar 27, 2024
garypen
approved these changes
Mar 27, 2024
nicholascioli
merged commit Mar 27, 2024
617b9b7
into
garypen/2002-subgraph-batching
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves handling of cancelled batch queries into the router service so that any custom rust plugin, rhai script, coprocessor, etc. will have cancelled requests handled without needing to handle batches specially.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩