Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move batch query cancellation up #4859

Conversation

nicholascioli
Copy link
Contributor

This commit moves handling of cancelled batch queries into the router service so that any custom rust plugin, rhai script, coprocessor, etc. will have cancelled requests handled without needing to handle batches specially.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@nicholascioli nicholascioli requested a review from garypen March 26, 2024 22:23
@nicholascioli nicholascioli self-assigned this Mar 26, 2024
@router-perf
Copy link

router-perf bot commented Mar 26, 2024

CI performance tests

  • reload - Reload test over a long period of time at a constant rate of users
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • large-request - Stress test with a 1 MB request payload
  • const - Basic stress test that runs with a constant number of users
  • no-graphos - Basic stress test, no GraphOS.
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • xlarge-request - Stress test with 10 MB request payload
  • step - Basic stress test that steps up the number of users over time

@nicholascioli nicholascioli marked this pull request as ready for review March 27, 2024 16:49
nicholascioli and others added 4 commits March 27, 2024 12:49
This commit moves handling of cancelled batch queries into the
router service so that any custom rust plugin, rhai script,
coprocessor, etc. will have cancelled requests handled without
needing to handle batches specially.
These tweaks are enough (I think) for us to make progress.

Let's review together and then decide how to proceed.
@nicholascioli nicholascioli force-pushed the nc/subgraph-batching/single-cancel-spot branch from 7e7e01a to 6c057ab Compare March 27, 2024 16:56
@nicholascioli nicholascioli merged commit 617b9b7 into garypen/2002-subgraph-batching Mar 27, 2024
12 checks passed
@nicholascioli nicholascioli deleted the nc/subgraph-batching/single-cancel-spot branch March 27, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants