Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[batching] fix subgraph unwrapping #4849

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

garypen
Copy link
Contributor

@garypen garypen commented Mar 26, 2024

Without this fix a null body would cause the router to panic.

With this fix, if a body is null, then the router returns an error to the user.

Ref: #4661

Without this fix a null body would cause the router to panic.

With this fix, if a body is null, then the router returns an error to
the user.
@garypen garypen requested a review from nicholascioli March 26, 2024 11:48
@garypen garypen self-assigned this Mar 26, 2024
@router-perf
Copy link

router-perf bot commented Mar 26, 2024

CI performance tests

  • reload - Reload test over a long period of time at a constant rate of users
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • large-request - Stress test with a 1 MB request payload
  • const - Basic stress test that runs with a constant number of users
  • no-graphos - Basic stress test, no GraphOS.
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • xlarge-request - Stress test with 10 MB request payload
  • step - Basic stress test that steps up the number of users over time

Copy link
Contributor

@nicholascioli nicholascioli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@garypen garypen merged commit 41d5826 into garypen/2002-subgraph-batching Mar 26, 2024
12 checks passed
@garypen garypen deleted the garypen/fix-subgraph-unwrap branch March 26, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants