Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set a default TTL for query plans #4588

Merged
merged 28 commits into from
Apr 5, 2024
Merged

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Feb 2, 2024

Fix #4473

This sets a default TTL for query plan caches, because right now the default is sto store query plans indefinitely, which does not make sense because they change with schema updates.
The PR is a bit verbose because to add that new default, we need to create a redundant structure for redis configuration (I tried const generics but serde won't support them)


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

Geal added 7 commits February 2, 2024 12:07
this will make sure plan generation differences between federation
versions carry over in the cache
this ensures the query can be processed immediately instead of waiting
for the roundtrip to Redis or sending the cached response to other in flight requests
@router-perf
Copy link

router-perf bot commented Feb 2, 2024

CI performance tests

  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • large-request - Stress test with a 1 MB request payload
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • reload - Reload test over a long period of time at a constant rate of users
  • no-graphos - Basic stress test, no GraphOS.
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • xxlarge-request - Stress test with 100 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • const - Basic stress test that runs with a constant number of users
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode

@Geal Geal force-pushed the geal/query-plan-cache-default-ttl branch from 568fb60 to fa7e641 Compare February 5, 2024 15:37
Base automatically changed from geal/query-plan-cache-prod to dev February 5, 2024 15:57
@Geal Geal requested review from BrynCooke and bnjjj February 6, 2024 09:04

This comment has been minimized.

@Geal Geal marked this pull request as ready for review February 6, 2024 09:05
@Geal Geal requested a review from o0Ignition0o March 26, 2024 11:38
@BrynCooke
Copy link
Contributor

I think there should be some sort of documentation update associated with this. @shorgi can we add a table for the options with defaults?

@Geal Geal requested a review from a team as a code owner April 2, 2024 13:52
@Geal
Copy link
Contributor Author

Geal commented Apr 2, 2024

there is some documentation now

@Geal
Copy link
Contributor Author

Geal commented Apr 2, 2024

actually maybe it would make sense to have a default expiration for APQ too 🤔

@Geal
Copy link
Contributor Author

Geal commented Apr 3, 2024

@BrynCooke @bnjjj @o0Ignition0o could I get a review for this PR? This has waited for 3 weeks already

@Geal Geal enabled auto-merge (squash) April 5, 2024 15:15
@Geal Geal merged commit ebbe6ec into dev Apr 5, 2024
13 of 14 checks passed
@Geal Geal deleted the geal/query-plan-cache-default-ttl branch April 5, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query Plan Caching Improvements
2 participants