-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set a default TTL for query plans #4588
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will make sure plan generation differences between federation versions carry over in the cache
this ensures the query can be processed immediately instead of waiting for the roundtrip to Redis or sending the cached response to other in flight requests
CI performance tests
|
12 tasks
Co-authored-by: Iryna Shestak <[email protected]>
Geal
force-pushed
the
geal/query-plan-cache-default-ttl
branch
from
February 5, 2024 15:37
568fb60
to
fa7e641
Compare
This comment has been minimized.
This comment has been minimized.
I think there should be some sort of documentation update associated with this. @shorgi can we add a table for the options with defaults? |
there is some documentation now |
actually maybe it would make sense to have a default expiration for APQ too 🤔 |
@BrynCooke @bnjjj @o0Ignition0o could I get a review for this PR? This has waited for 3 weeks already |
BrynCooke
approved these changes
Apr 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4473
This sets a default TTL for query plan caches, because right now the default is sto store query plans indefinitely, which does not make sense because they change with schema updates.
The PR is a bit verbose because to add that new default, we need to create a redundant structure for redis configuration (I tried const generics but serde won't support them)
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩