Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused crates from the project #4179

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Conversation

garypen
Copy link
Contributor

@garypen garypen commented Nov 9, 2023

Remove some unused crates and convert our redis tests to use the fred crate. That means we can remove our dev dependency on the redis crate.

This yielded a 1.5% reduction in test build time on my laptop.

Note: This is an exploratory PR, since it's fairly tricky to get unused crates information across multiple platforms with various conditional compilations in play.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

And add a lint which helps make sure we keep removing unused crates in
future.
@garypen garypen requested a review from a team November 9, 2023 16:46
@garypen garypen self-assigned this Nov 9, 2023
Copy link
Contributor

github-actions bot commented Nov 9, 2023

@garypen, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@router-perf
Copy link

router-perf bot commented Nov 9, 2023

CI performance tests

  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • large-request - Stress test with a 1 MB request payload
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • reload - Reload test over a long period of time at a constant rate of users
  • no-graphos - Basic stress test, no GraphOS.
  • xxlarge-request - Stress test with 100 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • const - Basic stress test that runs with a constant number of users

That enables us to remove our dev dependency on redis.
We use rstack in linux only tests.
It's interesting and has helped me find some small improvements, but I
don't think we can leave it always enabled because it is difficult to
debug other platforms (i.e. not the platform you are doing the
investigation on) and throws up some false positives.

Maybe worth repeating the experiment every X months and manually making
improvements.
@SimonSapin
Copy link
Contributor

I don’t find the lint in the diff. Is it meant to be a new file?

@garypen
Copy link
Contributor Author

garypen commented Nov 10, 2023

I don’t find the lint in the diff. Is it meant to be a new file?

fd4b54b

@Geal
Copy link
Contributor

Geal commented Nov 10, 2023

the goal of using a different client was to make sure that there's nothing specific to fred that would mess with the data, but we can remove it yes

@garypen
Copy link
Contributor Author

garypen commented Nov 10, 2023

the goal of using a different client was to make sure that there's nothing specific to fred that would mess with the data, but we can remove it yes

I did wonder about that, but concluded that we should be testing fred since it's our primary (in fact, only) client in the router. We could add back the old test if it's useful.

@garypen garypen merged commit 40759b9 into dev Nov 10, 2023
2 checks passed
@garypen garypen deleted the garypen/remove-unused-crates branch November 10, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants