Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apollo-compiler with a fix to enum recursions #4167

Merged
merged 7 commits into from
Nov 14, 2023

Conversation

lrlna
Copy link
Member

@lrlna lrlna commented Nov 8, 2023

This updates the Router with the latest apollo-compiler version, which contains a fix for unnecessarily recursive enums and unions.

Fixes #4142


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@lrlna lrlna self-assigned this Nov 8, 2023

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Nov 8, 2023

CI performance tests

  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • large-request - Stress test with a 1 MB request payload
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • reload - Reload test over a long period of time at a constant rate of users
  • no-graphos - Basic stress test, no GraphOS.
  • xxlarge-request - Stress test with 100 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • const - Basic stress test that runs with a constant number of users

@lrlna lrlna requested review from goto-bus-stop and Geal November 8, 2023 13:14
Copy link
Member

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically the counting was accurate, it just uses recursion less now!

@lrlna lrlna changed the title Update apollo-compiler with a fix to enum recursion calculations Update apollo-compiler with a fix to enum recursions Nov 8, 2023
@lrlna lrlna requested a review from SimonSapin November 8, 2023 16:33
Copy link
Contributor

@SimonSapin SimonSapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed another commit with a changelog entry.

@SimonSapin
Copy link
Contributor

Ugh sorry, not sure how I missed that you’d already added a changelog. I’ll deduplicate now.

@SimonSapin SimonSapin merged commit 6e426dd into dev Nov 14, 2023
2 checks passed
@abernix abernix mentioned this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parser recursion issue when compiling schema on startup
5 participants