Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorization: Fix fragment filtering #4155

Merged
merged 6 commits into from
Nov 8, 2023
Merged

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Nov 7, 2023

Fix #4060

If a fragment was removed, whether because its condition cannot be fulfilled or its selections were removed, then the corresponding fragment spreads must be removed from the filtered query.

This also fixes the error paths related to fragments: before, the path started at the fragment definition, while now the fragment's errors are added at the point of application


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Nov 7, 2023

CI performance tests

  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • large-request - Stress test with a 1 MB request payload
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • reload - Reload test over a long period of time at a constant rate of users
  • no-graphos - Basic stress test, no GraphOS.
  • xxlarge-request - Stress test with 100 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • const - Basic stress test that runs with a constant number of users

Geal added 2 commits November 7, 2023 11:37
if a fragment has been entirely removed, then we must remove the
fragment spreads too
@Geal Geal changed the title Authorization: add tests for filtered fragments Authorization: Fix fragment filtering Nov 7, 2023
@Geal Geal requested review from a team, garypen, SimonSapin and lrlna November 7, 2023 11:30
@Geal Geal enabled auto-merge (squash) November 8, 2023 11:40
@Geal Geal merged commit 0b62234 into dev Nov 8, 2023
2 checks passed
@Geal Geal deleted the geal/authz-filtered-fragments branch November 8, 2023 11:59
@abernix abernix mentioned this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

authz: remove a fragment spread if the fragment's selections are all removed
3 participants