Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serde deserialization for Extendable. #4123

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

BrynCooke
Copy link
Contributor

@BrynCooke BrynCooke commented Oct 31, 2023

Serde flatten doesn't do what we want it to do.
Custom Deserializer that will to the right thing, first trying a custom attribute and then a standard attribute.

Part of #3226


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@github-actions
Copy link
Contributor

@BrynCooke, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@router-perf
Copy link

router-perf bot commented Oct 31, 2023

CI performance tests

  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • large-request - Stress test with a 1 MB request payload
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • reload - Reload test over a long period of time at a constant rate of users
  • no-graphos - Basic stress test, no GraphOS.
  • xxlarge-request - Stress test with 100 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • const - Basic stress test that runs with a constant number of users

@BrynCooke BrynCooke requested a review from bnjjj October 31, 2023 13:21
@BrynCooke BrynCooke force-pushed the bryn/serde-madness branch 2 times, most recently from 6b05638 to 1ea731d Compare October 31, 2023 13:30
`flatten` doesn't do what we want.
Implement custom deserializer and add tests.

Part of #3226
@BrynCooke BrynCooke enabled auto-merge (squash) October 31, 2023 13:52
@BrynCooke BrynCooke merged commit 619bd01 into dev Oct 31, 2023
2 checks passed
@BrynCooke BrynCooke deleted the bryn/serde-madness branch October 31, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve / formalize configuration of telemetry / logging / observability / metrics / tracing
2 participants