Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate headers for source stream events with subscription #4057

Merged
merged 6 commits into from
Oct 20, 2023
Merged

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Oct 18, 2023

Fixes #3731


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

Signed-off-by: Benjamin Coenen <[email protected]>
@bnjjj bnjjj added the component/subscriptions Pertaining to GraphQL Subscriptions in the Router label Oct 18, 2023
@bnjjj bnjjj self-assigned this Oct 18, 2023
@github-actions

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Oct 18, 2023

CI performance tests

  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • large-request - Stress test with a 1 MB request payload
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • reload - Reload test over a long period of time at a constant rate of users
  • no-graphos - Basic stress test, no GraphOS.
  • xxlarge-request - Stress test with 100 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • const - Basic stress test that runs with a constant number of users

@bnjjj bnjjj marked this pull request as draft October 18, 2023 14:24
bnjjj added 2 commits October 19, 2023 11:49
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
@bnjjj bnjjj marked this pull request as ready for review October 19, 2023 09:57
Copy link
Contributor

@Geal Geal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with the caveat that the current request types encourage wrong decisions, like having the headers plugin extract headers from the supergraph request at the subgraph service plugin, instead of extracting at the router service level, putting the data in the context and then using in the subgraph service.
All of that will have to change when we implement #3400

@bnjjj bnjjj requested a review from BrynCooke October 19, 2023 13:27
@bnjjj bnjjj enabled auto-merge October 20, 2023 09:58
@bnjjj bnjjj merged commit b759284 into dev Oct 20, 2023
1 of 2 checks passed
@bnjjj bnjjj deleted the bnjjj/fix_3731 branch October 20, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/subscriptions Pertaining to GraphQL Subscriptions in the Router
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscriptions: Headers for source stream events aren't propagated to subgraphs
3 participants