-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify resource handling #4034
Merged
Merged
Unify resource handling #4034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
CI performance tests
|
BrynCooke
force-pushed
the
bryn/unify-resources
branch
4 times, most recently
from
October 13, 2023 10:30
5585696
to
3a783cd
Compare
BrynCooke
force-pushed
the
bryn/unify-resources
branch
6 times, most recently
from
October 13, 2023 14:10
a21256c
to
541cd67
Compare
The telemetry code had separate logic for constructing resources to pass to tracing and metrics exporters. This has now been unified and tests added. As a consequence, the default service.name for the router in tracing has now been brought into line with the otel spec, where if unspecified the value will be `unknown_service`.
BrynCooke
force-pushed
the
bryn/unify-resources
branch
from
October 13, 2023 14:38
541cd67
to
e670ae1
Compare
garypen
approved these changes
Oct 16, 2023
o0Ignition0o
approved these changes
Oct 17, 2023
Co-authored-by: Jeremy Lempereur <[email protected]>
Open
28 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The telemetry code had separate logic for constructing resources to pass to tracing and metrics exporters. This has now been unified and tests added.
As a consequence, the default service.name for the router in tracing has now been brought into line with the otel spec, where if unspecified the value will be
unknown_service
.Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩