Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify resource handling #4034

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Unify resource handling #4034

merged 3 commits into from
Oct 17, 2023

Conversation

BrynCooke
Copy link
Contributor

The telemetry code had separate logic for constructing resources to pass to tracing and metrics exporters. This has now been unified and tests added.

As a consequence, the default service.name for the router in tracing has now been brought into line with the otel spec, where if unspecified the value will be unknown_service.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@github-actions

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Oct 12, 2023

CI performance tests

  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • large-request - Stress test with a 1 MB request payload
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • reload - Reload test over a long period of time at a constant rate of users
  • no-graphos - Basic stress test, no GraphOS.
  • xxlarge-request - Stress test with 100 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • const - Basic stress test that runs with a constant number of users

@BrynCooke BrynCooke force-pushed the bryn/unify-resources branch 4 times, most recently from 5585696 to 3a783cd Compare October 13, 2023 10:30
@BrynCooke BrynCooke requested a review from a team as a code owner October 13, 2023 10:30
@BrynCooke BrynCooke force-pushed the bryn/unify-resources branch 6 times, most recently from a21256c to 541cd67 Compare October 13, 2023 14:10
@BrynCooke BrynCooke requested review from a team, Geal, bnjjj and o0Ignition0o October 13, 2023 14:36
The telemetry code had separate logic for constructing resources to pass to tracing and metrics exporters. This has now been unified and tests added.

As a consequence, the default service.name for the router in tracing has now been brought into line with the otel spec, where if unspecified the value will be `unknown_service`.
@BrynCooke BrynCooke force-pushed the bryn/unify-resources branch from 541cd67 to e670ae1 Compare October 13, 2023 14:38
@BrynCooke BrynCooke requested a review from garypen October 13, 2023 15:07
.changesets/fix_bryn_unify_resources.md Outdated Show resolved Hide resolved
@BrynCooke BrynCooke merged commit d949232 into dev Oct 17, 2023
2 checks passed
@BrynCooke BrynCooke deleted the bryn/unify-resources branch October 17, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants