-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix defaulting in router config #4010
Conversation
@BrynCooke, please consider creating a changeset entry in |
CI performance tests
|
07cd323
to
b86a209
Compare
b86a209
to
51266d0
Compare
source = "registry+https://github.com/rust-lang/crates.io-index" | ||
checksum = "a99485caec5e9d587a3780cd6ed06a546f9924071315ab7280e148536e7ab148" | ||
dependencies = [ | ||
"quote 0.6.13", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’d be nice if this new crate can use version 1.0 of quote and syn, to avoid compiling multiple versions of those libraries. But this isn’t a blocker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do this, release 0.1.1 and renovate can pick it up later.
There are two types of serde defaulting:
Container level defaulting will use an instance of the default implementation and take missing fields from it. Field level defaulting uses either the default implementation or optionally user supplied function to initialize missing fields.
When using field level defaulting it is essential that the Default implementation of a struct exactly match the serde annotations.
A test checks to ensure that field level defaulting is not used in conjunction with a Default implementation and gives guidance on resolution.
Description here
Fixes #4000
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩