-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename helm template from common\. to apollographql\. #4005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a naming clash with bitnami common templates used in other charts. This is unfortunate when used in a chart which has multiple dependencies where names may clash. The straightforward fix is to rename our templates from common to apollo. fixes: #4002
This comment has been minimized.
This comment has been minimized.
CI performance tests
|
garypen
changed the title
rename template from common\. to apollo\.
rename helm template from common\. to apollo\.
Oct 9, 2023
it's clearly our name
garypen
changed the title
rename helm template from common\. to apollo\.
rename helm template from common\. to apollographql\.
Oct 9, 2023
Geal
approved these changes
Oct 19, 2023
o0Ignition0o
added a commit
that referenced
this pull request
Nov 3, 2023
Followup to #4005, this updates the name where we forgot to, so we can cut an other alpha and deploy the chart.
o0Ignition0o
added a commit
that referenced
this pull request
Nov 3, 2023
Followup to #4005 , this updates the name where we forgot to, so we can cut an other alpha and deploy the chart.
o0Ignition0o
added a commit
that referenced
this pull request
Nov 3, 2023
Followup to #4005 , this updates the name where we forgot to, so we can cut an other alpha and deploy the chart.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a naming clash with bitnami common templates used in other charts. This is unfortunate when used in a chart which has multiple dependencies where names may clash.
The straightforward fix is to rename our templates from common to apollographql.
fixes: #4002
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩