Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename helm template from common\. to apollographql\. #4005

Merged
merged 4 commits into from
Oct 30, 2023

Conversation

garypen
Copy link
Contributor

@garypen garypen commented Oct 9, 2023

There is a naming clash with bitnami common templates used in other charts. This is unfortunate when used in a chart which has multiple dependencies where names may clash.

The straightforward fix is to rename our templates from common to apollographql.

fixes: #4002


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

There is a naming clash with bitnami common templates used in other
charts. This is unfortunate when used in a chart which has multiple
dependencies where names may clash.

The straightforward fix is to rename our templates from common to
apollo.

fixes: #4002
@garypen garypen requested a review from a team October 9, 2023 16:47
@garypen garypen self-assigned this Oct 9, 2023
@garypen garypen requested review from Geal, SimonSapin and bnjjj October 9, 2023 16:47
@github-actions

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Oct 9, 2023

CI performance tests

  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • large-request - Stress test with a 1 MB request payload
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • reload - Reload test over a long period of time at a constant rate of users
  • no-graphos - Basic stress test, no GraphOS.
  • xxlarge-request - Stress test with 100 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • const - Basic stress test that runs with a constant number of users

@garypen garypen changed the title rename template from common\. to apollo\. rename helm template from common\. to apollo\. Oct 9, 2023
it's clearly our name
@garypen garypen changed the title rename helm template from common\. to apollo\. rename helm template from common\. to apollographql\. Oct 9, 2023
@garypen garypen marked this pull request as ready for review October 16, 2023 09:21
@garypen garypen merged commit e418d32 into dev Oct 30, 2023
1 of 2 checks passed
@garypen garypen deleted the garypen/4002-rename-common branch October 30, 2023 10:37
o0Ignition0o added a commit that referenced this pull request Nov 3, 2023
Followup to #4005, this updates the name where we forgot to, so we can cut an other alpha and deploy the chart.
o0Ignition0o added a commit that referenced this pull request Nov 3, 2023
Followup to #4005 , this updates the name where we forgot to, so we can
cut an other alpha and deploy the chart.
o0Ignition0o added a commit that referenced this pull request Nov 3, 2023
Followup to #4005 , this updates the name where we forgot to, so we can
cut an other alpha and deploy the chart.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Helm]: Duplication of common chart template causes conflicts
2 participants