Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router should respond with subscription-protocol header for callback #3939

Merged
merged 6 commits into from
Oct 19, 2023

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Sep 29, 2023

Callback protocol documentation specifies that router responds with subscription-protocol: callback/1.0 header to the initialization (check) message. Currently router does not set this header on the response.

Fixes #3929

@bnjjj bnjjj self-assigned this Sep 29, 2023
@router-perf
Copy link

router-perf bot commented Sep 29, 2023

CI performance tests

  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • large-request - Stress test with a 1 MB request payload
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • reload - Reload test over a long period of time at a constant rate of users
  • no-graphos - Basic stress test, no GraphOS.
  • xxlarge-request - Stress test with 100 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • const - Basic stress test that runs with a constant number of users

Signed-off-by: Benjamin Coenen <[email protected]>
@bnjjj bnjjj requested review from o0Ignition0o and Geal September 29, 2023 15:31
@bnjjj bnjjj enabled auto-merge October 19, 2023 14:01
Signed-off-by: Benjamin Coenen <[email protected]>
@bnjjj bnjjj merged commit d9791dc into dev Oct 19, 2023
2 checks passed
@bnjjj bnjjj deleted the bnjjj/fix_3929 branch October 19, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

callback: router should respond with subscription-protocol: callback header
2 participants