Move persisted queries from preview to general availability #3914
Conversation
This comment has been minimized.
This comment has been minimized.
|
CI performance tests
|
Persisted Queries (https://www.apollographql.com/docs/graphos/operations/persisted-queries/), a GraphOS Enterprise feature, is now moving to General Availability, from Preview where it has been since Apollo Router 1.25. For more information about launch stages, please see the documentation here: https://www.apollographql.com/docs/resources/product-launch-stages/ The feature is now configured with a `persisted_queries` top-level key in the YAML configuration instead of with `preview_persisted_queries`. Existing configuration files will keep working as before, only with a warning. To fix that warning, rename the configuration section like so: ```diff -preview_persisted_queries: +persisted_queries: enabled: true ```
glasser
force-pushed
the
glasser/persisted-queries-ga
branch
from
415245d to
f7a901d
Compare
|
This PR was heavily inspired by #3356. |
| @@ -206,7 +206,7 @@ impl Metrics { | |||
| ); | |||
| log_usage_metrics!( | |||
| value.apollo.router.config.persisted_queries, | |||
| "$.preview_persisted_queries[?(@.enabled == true)]", | |||
| "$.persisted_queries[?(@.enabled == true)]", | |||
There was a problem hiding this comment.
@BrynCooke I just want to double-check my understanding that this expression is only ever applied to a YAML file that has been "migrated".
| @@ -0,0 +1,5 @@ | |||
| description: Persisted queries are no longer preview, `preview_persisted_queries` is renamed `persisted_queries` | |||
There was a problem hiding this comment.
Text chosen for consistency with 0008, though I would probably use a semicolon and add "to" after "renamed"
| @@ -178,7 +178,7 @@ impl LicenseEnforcementReport { | |||
| .name("Operation aliases limiting") | |||
| .build(), | |||
| ConfigurationRestriction::builder() | |||
| .path("$.preview_persisted_queries") | |||
| .path("$.persisted_queries") | |||
There was a problem hiding this comment.
Similarly want to double-check my understanding that this expression is only ever applied to a YAML file that has been "migrated".
There was a problem hiding this comment.
Yes, both license enforcement and metrics are applied to Configuration::validated_yaml which has already had migrations applied.
| @@ -6,8 +6,6 @@ minVersion: 1.25.0 | |||
|
|
|||
| <GraphOSEnterpriseRequired /> | |||
|
|
|||
| <PreviewFeature discordLink="https://discordapp.com/channels/1022972389463687228/1143901714173407342"/> | |||
There was a problem hiding this comment.
Note that there are other references to "preview" on this page, but they are loaded via components in the docs repo.
There was a problem hiding this comment.
Thanks for this @glasser ! Will keep an eye out here for the final configuration name and update apollographql/docs#565 accordingly
Persisted Queries
(https://www.apollographql.com/docs/graphos/operations/persisted-queries/), a GraphOS Enterprise feature, is now moving to General Availability, from Preview where it has been since Apollo Router 1.25.
For more information about launch stages, please see the documentation here:
https://www.apollographql.com/docs/resources/product-launch-stages/
The feature is now configured with a
persisted_queriestop-level key in the YAML configuration instead of withpreview_persisted_queries. Existing configuration files will keep working as before, only with a warning. To fix that warning, rename the configuration section like so: