Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exposing topologySpreadConstraints on the helm chart #3892

Merged
merged 5 commits into from
Oct 5, 2023
Merged

exposing topologySpreadConstraints on the helm chart #3892

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5325a48
exposing topologySpreadConstraints on the helm chart
bjoernw Sep 22, 2023
d0aa88c
exposing topologySpreadConstraints on the helm chart
bjoernw Sep 22, 2023
cfe1764
exposing topologySpreadConstraints on the helm chart
bjoernw Sep 22, 2023
500e1c6
Merge branch 'dev' into expose-topology-spread-constraints
garypen Oct 3, 2023
00126a4
Update helm/chart/router/values.yaml
bjoernw Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changesets/feat_expose_topology_spread_constraints.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
### Expose the ability to set topology spread constraints on the helm chart ([3891](https://github.com/apollographql/router/issues/3891))

Give developers the ability to set topology spread constraints that can be used to guarantee that federation pods are spread out evenly across AZs.

By [bjoern](https://github.com/bjoernw) in https://github.com/apollographql/router/pull/3892
4 changes: 4 additions & 0 deletions helm/chart/router/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,3 +162,7 @@ spec:
{{- if .Values.terminationGracePeriodSeconds }}
terminationGracePeriodSeconds: {{ .Values.terminationGracePeriodSeconds }}
{{- end }}
{{- with .Values.topologySpreadConstraints }}
topologySpreadConstraints:
{{- toYaml . | nindent 8 }}
{{- end }}
9 changes: 9 additions & 0 deletions helm/chart/router/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,3 +232,12 @@ probes:
# -- Configure liveness probe
liveness:
initialDelaySeconds: 0

topologySpreadConstraints: []
# topologySpreadConstraints:
# - maxSkew: 1
# topologyKey: kubernetes.io/hostname
# whenUnsatisfiable: ScheduleAnyway
# - maxSkew: 1
# topologyKey: topology.kubernetes.io/zone
# whenUnsatisfiable: ScheduleAnyway
bjoernw marked this conversation as resolved.
Show resolved Hide resolved