Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preverify release version #3859

Merged
merged 6 commits into from
Sep 22, 2023
Merged

preverify release version #3859

merged 6 commits into from
Sep 22, 2023

Conversation

BrynCooke
Copy link
Contributor

@BrynCooke BrynCooke commented Sep 20, 2023

Adds a new xtask release pre-verify

Adds a check that the cargo toml matches the local tagged tree.

Fixes #3664


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@github-actions
Copy link
Contributor

@BrynCooke, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@router-perf
Copy link

router-perf bot commented Sep 20, 2023

CI performance tests

  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • large-request - Stress test with a 1 MB request payload
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • reload - Reload test over a long period of time at a constant rate of users
  • no-graphos - Basic stress test, no GraphOS.
  • xxlarge-request - Stress test with 100 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • const - Basic stress test that runs with a constant number of users

@BrynCooke BrynCooke changed the title Bryn/preverify release preverify release version Sep 20, 2023
@BrynCooke BrynCooke requested a review from abernix September 20, 2023 12:52
@BrynCooke BrynCooke marked this pull request as ready for review September 20, 2023 13:51
.circleci/config.yml Outdated Show resolved Hide resolved
xtask/src/commands/release.rs Outdated Show resolved Hide resolved
@BrynCooke BrynCooke requested a review from abernix September 22, 2023 10:45
@BrynCooke BrynCooke merged commit aa85b15 into dev Sep 22, 2023
@BrynCooke BrynCooke deleted the bryn/preverify-release branch September 22, 2023 13:06
abernix added a commit that referenced this pull request Sep 22, 2023
Follows-up: #3859

This builds on the successful deployment of the `pre_verify_release` step but makes it an actual pre-flight checklist rather than something that runs in parallel to the existing jobs.
abernix added a commit that referenced this pull request Sep 25, 2023
Follows-up: #3859

This builds on the successful deployment of the `pre_verify_release`
step but makes it an actual pre-flight checklist rather than something
that runs in parallel to the existing jobs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release process should check project files to see that versions match the git tag
2 participants