Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fewer header manipulations and allocations #3844

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Sep 18, 2023

HeaderName::from_static and HeaderValue::from_static can avoid allocations, but we do not get the full benefit from this function by calling them directly in the code: They are const functions, so their result should be stored in a const or static value, then reused elsewhere.
This also removes some unneeded header allocations when handling client name and client version


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

HeaderName::from_static and HeaderCalue::from_static can avoid
allocations, but we do not get the full benefit from this function by
calling them directly in the code: They are const functions, so their
result should be stored in a const or static value, then reused
elsewhere.
This also removes some unneeded header allocations when handling client
name and client version
@github-actions
Copy link
Contributor

@Geal, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@router-perf
Copy link

router-perf bot commented Sep 18, 2023

CI performance tests

  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • large-request - Stress test with a 1 MB request payload
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • reload - Reload test over a long period of time at a constant rate of users
  • no-graphos - Basic stress test, no GraphOS.
  • xxlarge-request - Stress test with 100 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • const - Basic stress test that runs with a constant number of users

@Geal Geal changed the title less header manipluations and allocations less header manipulations and allocations Sep 18, 2023
@garypen garypen changed the title less header manipulations and allocations fewer header manipulations and allocations Sep 20, 2023
@Geal Geal requested review from a team, SimonSapin, BrynCooke and o0Ignition0o September 20, 2023 15:58
@Geal Geal merged commit 3f46814 into dev Sep 22, 2023
@Geal Geal deleted the geal/less-header-allocations branch September 22, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants