Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(telemetry): do not display otel bug if the trace is sampled #3832

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Sep 15, 2023

We changed the way we are sampling spans. If you had logs in an evicted span it displays that log Unable to find OtelData in extensions; this is a bug which is incorrect, it's not a bug, we just can't display the trace_id because there is no trace_id as the span has not been sampled.

Fixes #issue_number


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@bnjjj bnjjj self-assigned this Sep 15, 2023
@github-actions

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Sep 15, 2023

CI performance tests

  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • large-request - Stress test with a 1 MB request payload
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • reload - Reload test over a long period of time at a constant rate of users
  • no-graphos - Basic stress test, no GraphOS.
  • xxlarge-request - Stress test with 100 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • const - Basic stress test that runs with a constant number of users

Signed-off-by: Benjamin Coenen <[email protected]>
@bnjjj bnjjj added the bug label Sep 15, 2023
@bnjjj bnjjj merged commit 641bfac into dev Sep 15, 2023
@bnjjj bnjjj deleted the bnjjj/fix_otel_data_from_log branch September 15, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants