Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not run test_subscription if graph ref and apollo key is not set for tests #3813

Merged
merged 1 commit into from
Sep 13, 2023
Merged

do not run test_subscription if graph ref and apollo key is not set for tests #3813

merged 1 commit into from
Sep 13, 2023

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Sep 13, 2023

No description provided.

@bnjjj bnjjj self-assigned this Sep 13, 2023
@bnjjj bnjjj enabled auto-merge (squash) September 13, 2023 09:06
@github-actions
Copy link
Contributor

@bnjjj, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@router-perf
Copy link

router-perf bot commented Sep 13, 2023

CI performance tests

  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • large-request - Stress test with a 1 MB request payload
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • reload - Reload test over a long period of time at a constant rate of users
  • no-graphos - Basic stress test, no GraphOS.
  • xxlarge-request - Stress test with 100 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • const - Basic stress test that runs with a constant number of users

o0Ignition0o
o0Ignition0o approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@o0Ignition0o o0Ignition0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would have returned early, but lgtm!

@bnjjj bnjjj merged commit e496f74 into dev Sep 13, 2023
@bnjjj bnjjj deleted the bnjjj/fix_subscription_test_guard branch September 13, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@o0Ignition0o o0Ignition0o o0Ignition0o approved these changes

@Geal Geal Geal approved these changes

Assignees

@bnjjj bnjjj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bnjjj @Geal @o0Ignition0o