Fix: deal with interface inheritance when retrieving selectionset #3793
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #3718, this changeset makes sure we're able to generate the most concrete selection set for a given operation.
This means finding the most concrete type we can when we're dealing with interfaces:
Given the following invariants:
For
The most concrete interface to generate fields for
OperationItemStuff
is notOperationItem
, so we narrow down the selection toOperationItemStuff
.The fixes for #3718 still apply, IE:
Given the following invariants:
For
The most concrete type to generate a selection set for
Dog
is notAnimal
, so we narrow down the selection toDog
.