-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prep release: v1.29.0 #3734
Merged
Merged
prep release: v1.29.0 #3734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI performance tests
|
abernix
reviewed
Sep 4, 2023
abernix
reviewed
Sep 4, 2023
Geal
commented
Sep 4, 2023
abernix
reviewed
Sep 4, 2023
Co-authored-by: Jesse Rosenberger <[email protected]>
Geal
commented
Sep 4, 2023
abernix
reviewed
Sep 4, 2023
Co-authored-by: Jesse Rosenberger <[email protected]>
abernix
reviewed
Sep 4, 2023
Co-authored-by: Jesse Rosenberger <[email protected]>
chandrikas
reviewed
Sep 4, 2023
Co-authored-by: Chandrika Srinivasan <[email protected]>
chandrikas
reviewed
Sep 4, 2023
Co-authored-by: Chandrika Srinivasan <[email protected]>
BrynCooke
reviewed
Sep 4, 2023
Co-authored-by: Bryn Cooke <[email protected]>
chandrikas
reviewed
Sep 4, 2023
BrynCooke
reviewed
Sep 4, 2023
Co-authored-by: Chandrika Srinivasan <[email protected]> Co-authored-by: Bryn Cooke <[email protected]>
abernix
reviewed
Sep 4, 2023
chandrikas
reviewed
Sep 4, 2023
Geal
commented
Sep 4, 2023
abernix
reviewed
Sep 4, 2023
Co-authored-by: Jesse Rosenberger <[email protected]>
Geal
commented
Sep 4, 2023
Geal
commented
Sep 4, 2023
Geal
commented
Sep 4, 2023
abernix
approved these changes
Sep 4, 2023
abernix
reviewed
Sep 4, 2023
chandrikas
approved these changes
Sep 4, 2023
BrynCooke
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Features
GraphOS Enterprise: authorization directives (PR #3397, PR #3662)
We introduce two new directives,
requiresScopes
and@authenticated
, that define authorization policies for fields and types in the supergraph schema.They are defined as follows:
The implementation hooks into the request lifecycle at multiple steps:
@requiresScopes
, this is the intersection of the query's required scopes and the scopes provided in the request token@authenticated
, it isis_authenticated
or notBy @Geal in #3397 #3662
🐛 Fixes
Update deno, so we can generate docs again (Issue #3305)
Router docs failed to build on crates.io because of a documentation compile error in Deno.
This updates Deno to the latest version, which allows us to generate crates.io documentation again.
By @o0Ignition0o in #3626
Fix config metrics path and test for subscription callbacks (Issue #3687)
Detection of subscription callbacks has been fixed for internal Apollo metrics. This has no user facing impact.
By @BrynCooke in #3688
GraphQL response processing must happen under the execution span (PR #3732)
Previously, any event in processing would be reported under the supergraph span, or any plugin span (like rhai) happening in between
By @Geal in #3732
🛠 Maintenance
Uplink connections now reuse reqwest client (Issue #3333)
Previously uplink requests created a new reqwest client each time, this may cause CPU spikes especially on OSX.
A single client will now be shared between requests of the same type.
By @BrynCooke in #3703
Add a metric tracking authorization usage (PR #3660)
The new metric is a counter called
apollo.router.operations.authorization
and contains the following boolean attributes:filtered
: the query has one or more filtered fieldsrequires_scopes
: the query uses fields or types tagged with the@requiresScopes
directiveauthenticated
: the query uses fields or types tagged with the@authenticated
directiveBy @Geal in #3660
Remove unneeded schema parsing steps (PR #3547)
We need access to a parsed schema in various parts of the router, sometimes before the point where it is actually parsed and integrated with the rest of the configuration, so it was parsed multiple times to mitigate that. Some architecture changes made these parsing steps obsolete so they were removed.
By @Geal in #3547