Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removes unused introspector-gadget crate #3709

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Conversation

EverlastingBugstopper
Copy link
Contributor

This PR removes the introspector-gadget dependency from the Cargo.toml as I don't believe it's used by this crate anymore. If this passes I think I'd like to deprecate that crate and move it fully back into the Rover repository so it's easier to make changes to its implementation.

@router-perf
Copy link

router-perf bot commented Aug 30, 2023

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • const - Basic stress test that runs with a constant number of users
  • reload - Reload test over a long period of time at a constant rate of users
  • large-request - Stress test with a 1 MB request payload
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • no-graphos - Basic stress test, no GraphOS.

@github-actions
Copy link
Contributor

@EverlastingBugstopper, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@bnjjj bnjjj merged commit b8efa32 into dev Sep 4, 2023
@bnjjj bnjjj deleted the avery/removes-unused-dep branch September 4, 2023 14:37
garypen pushed a commit that referenced this pull request Sep 12, 2023
This PR removes the `introspector-gadget` dependency from the
`Cargo.toml` as I don't believe it's used by this crate anymore. If this
passes I think I'd like to deprecate that crate and move it fully back
into the Rover repository so it's easier to make changes to its
implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants