Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supergraph coprocessor implementation #3647

Merged
merged 17 commits into from
Sep 14, 2023
Merged

Supergraph coprocessor implementation #3647

merged 17 commits into from
Sep 14, 2023

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Aug 22, 2023

Description here

Fixes #issue_number

Checklist

Complete the checklist (and note appropriate exceptions) before a final PR is raised.

  • Changes are compatible[^1]
  • Documentation[^2] completed
  • Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

[^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.
[^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples.
[^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests:
- please document the manual testing (extensively) in the Exceptions.
- please raise a separate issue to automate the test and label it (or ask for it to be labeled) as manual test

@Geal Geal requested a review from a team as a code owner August 22, 2023 14:24
@github-actions

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Aug 22, 2023

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • const - Basic stress test that runs with a constant number of users
  • reload - Reload test over a long period of time at a constant rate of users
  • large-request - Stress test with a 1 MB request payload
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • no-graphos - Basic stress test, no GraphOS.

@Geal Geal requested review from a team, garypen, bnjjj and o0Ignition0o August 22, 2023 15:16
Comment on lines +201 to +202
.and_method(method)
.and_sdl(sdl_to_send)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

CHANGELOG.md Outdated Show resolved Hide resolved
.changesets/feat_geal_supergraph_coprocessor2.md Outdated Show resolved Hide resolved
@Geal Geal requested review from BrynCooke and removed request for garypen August 30, 2023 14:09
Copy link
Contributor

@BrynCooke BrynCooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs the metric added:
apollo.router.operations.coprocessor

Plus update the test for apollo.router.config.coprocessor to ensure that it is doing the right thing.

@Geal
Copy link
Contributor Author

Geal commented Sep 5, 2023

Needs the metric added:
apollo.router.operations.coprocessor

cb4d33b

Plus update the test for apollo.router.config.coprocessor to ensure that it is doing the right thing.

773bd02

@Geal Geal requested a review from BrynCooke September 5, 2023 10:11
@Geal Geal merged commit cf19df6 into dev Sep 14, 2023
2 checks passed
@Geal Geal deleted the geal/supergraph-coprocessor2 branch September 14, 2023 07:59
@lrlna lrlna mentioned this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants