Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enable checking for kubernetes 1.28.0 in kubeconform #3638

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

garypen
Copy link
Contributor

@garypen garypen commented Aug 22, 2023

Support has now been added for kubernetes 1.28.0 and we can re-enable checking.

This is reverting the change from #3584.

fixes: #3587

Checklist

Complete the checklist (and note appropriate exceptions) before a final PR is raised.

  • Changes are compatible[^1]
  • Documentation[^2] completed
  • Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

[^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.
[^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples.
[^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests:
- please document the manual testing (extensively) in the Exceptions.
- please raise a separate issue to automate the test and label it (or ask for it to be labeled) as manual test

Support has now been added for kubernetes `1.28.0` and we can re-enable
checking.

This is reverting the change from #3584.

fixes: #3587
@garypen garypen self-assigned this Aug 22, 2023
@github-actions

This comment has been minimized.

@garypen garypen requested review from a team, SimonSapin, bnjjj and o0Ignition0o August 22, 2023 11:00
@router-perf
Copy link

router-perf bot commented Aug 22, 2023

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • const - Basic stress test that runs with a constant number of users
  • reload - Reload test over a long period of time at a constant rate of users
  • large-request - Stress test with a 1 MB request payload
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • no-graphos - Basic stress test, no GraphOS.

@garypen garypen changed the title Enable checking for kubernetes 1.28.0 in kubeconform chore: Enable checking for kubernetes 1.28.0 in kubeconform Aug 22, 2023
@garypen garypen enabled auto-merge (squash) August 22, 2023 11:45
@garypen garypen merged commit e82a701 into dev Aug 22, 2023
@garypen garypen deleted the garypen/3587-enable-1.28.0 branch August 22, 2023 12:13
@BrynCooke BrynCooke mentioned this pull request Aug 24, 2023
garypen added a commit that referenced this pull request Aug 25, 2023
Support has now been added for kubernetes `1.28.0` and we can re-enable
checking.

This is reverting the change from #3584.

fixes: #3587

<!-- start metadata -->

**Checklist**

Complete the checklist (and note appropriate exceptions) before a final
PR is raised.

- [x] Changes are compatible[^1]
- [x] Documentation[^2] completed
- [x] Performance impact assessed and acceptable
- Tests added and passing[^3]
    - [ ] Unit Tests
    - [ ] Integration Tests
    - [ ] Manual Tests

**Exceptions**

*Note any exceptions here*

**Notes**

[^1]. It may be appropriate to bring upcoming changes to the attention
of other (impacted) groups. Please endeavour to do this before seeking
PR approval. The mechanism for doing this will vary considerably, so use
your judgement as to how and when to do this.
[^2]. Configuration is an important part of many changes. Where
applicable please try to document configuration examples.
[^3]. Tick whichever testing boxes are applicable. If you are adding
Manual Tests:
- please document the manual testing (extensively) in the Exceptions.
- please raise a separate issue to automate the test and label it (or
ask for it to be labeled) as `manual test`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Re-enable helm+kubeconfiorm test for Kubernetes v1.28.0, eventually.
2 participants