-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for AWS X-Ray Tracing Propagator #3580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this. I actually came across another issue about this today and finally got around to leaving my comment on it. Maybe you could respond there? #3445 (comment)
Other than that, one comment within here, though as my question on the other issue will elude to, I'm curious if this could just be done with the existing "custom header" option that exists and how this differs, in practice.
Thanks again!
@@ -81,6 +81,9 @@ telemetry: | |||
# https://zipkin.io/ (compliant with opentracing) | |||
zipkin: false | |||
|
|||
# https://aws.amazon.com/xray/ (compliant with opentracing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(compliant with opentracing)
I'm actually curious what this comment means (even on the other options). Is it compatible? What makes it so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that It means that the format is compatible with the OpenTelemetry OTLP exporter/collector.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"OpenTelemetry" makes sense, but I was more curious about "OpenTracing" (which is different, as I understand it).
However, your uncertainty here is totally fine. I only asked because I thought maybe you'd perhaps made understanding of it already. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yeah. It looks like OpenTracing was merged into OpenTelemetry. Perhaps the comments should be updated.
@scottmace: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
CI performance tests
|
Note that I think the tests are failing because of the need to commit the changes after reviewing snapshot changes with |
@scottmace Thanks ! It looks good! Sorry for the delay, could you generate a small changeset for that pr ? Using |
Adds support for the OpenTelemetry AWS X-Ray tracing [propagator](https://docs.rs/opentelemetry-aws/latest/opentelemetry_aws/). This propagator helps propagate tracing information from upstream services (such as AWS load balancers) to downstream services and handles conversion between the X-Ray trace id format and OpenTelemetry span contexts.
Adds support for the OpenTelemetry AWS X-Ray tracing propagator.
This propagator helps propagate tracing information from upstream services (such as AWS load balancers) to downstream services and handles conversion between the X-Ray trace id format and OpenTelemetry span contexts.
Checklist
Complete the checklist (and note appropriate exceptions) before a final PR is raised.
Exceptions
Note any exceptions here
Notes
[^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.
[^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples.
[^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests:
- please document the manual testing (extensively) in the Exceptions.
- please raise a separate issue to automate the test and label it (or ask for it to be labeled) as
manual test