-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update opentelemetry to 0.19.0 #3196
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've commented out the call to a non-existent method (with_memory()), which seems like all I can do right now. I'm not sure what the impact of that is, so ...
This comment has been minimized.
This comment has been minimized.
CI performance tests
|
- add the new otel attributes to the prometheus tests - rename the match to include "_total" in the name I'm not sure if that second change is correct. I think it is, because I think the original behaviour (which appears to have changed) was a bit looser and accepted a less specific name (looks like a synonym). However, I'm not a prometheus file format expert, so I'll need to verify that.
garypen
requested review from
a team,
Geal,
BrynCooke,
bnjjj and
SimonSapin
and removed request for
BrynCooke
June 1, 2023 16:27
bnjjj
approved these changes
Jun 2, 2023
to see what happens
would love to see this go in |
Geal
approved these changes
Jun 5, 2023
o0Ignition0o
added a commit
that referenced
this pull request
Jun 15, 2023
This reverts commit 2ca2d73.
o0Ignition0o
added a commit
that referenced
this pull request
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update requires a change to the implementation and test update as follows:
with_memory(bool)
method which we were using when building our prometheus exporter. AFAICT, this used to be a mechanism for controlling how metrics handled stale gauges. In 0.19.0, this method was removed and now gauges are all assumed to be as though they were created withfalse
. We had been providingtrue
on our call. I'm not 100% certain of the impact of this change, but it appears that we can ignore it. We may need to consider it more carefully if problems arise.otel_scope_name="apollo/router",otel_scope_version=""
added to output and a number of tests had to be updated to accommodate that change.apollo_router_cache_hit_count
(and this was working) when it should have been searching forapollo_router_cache_hit_count_total
(likewise for miss). I've updated the test and think this is the correct thing to do. It looks like a bug was fixed in otel and this change matches the fix.The upgrade fixes many of the outstanding issues related to opentelemetry and various APM vendors:
Fixes: #2878
Fixes: #2066
Fixes: #2959
Fixes: #2225
Fixes: #1520
Checklist
Complete the checklist (and note appropriate exceptions) before a final PR is raised.
Exceptions
Note any exceptions here
Notes
[^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.
[^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples.
[^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests:
- please document the manual testing (extensively) in the Exceptions.
- please raise a separate issue to automate the test and label it (or ask for it to be labeled) as
manual test