fix histogram metrics in OTLP #2564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with the inexpensive selector, histogram are only reported as gauges, and so they will be incorrectly interpreted when reaching Datadog
This comment has been minimized.
This comment has been minimized.
|
I'm not fixed on the list of buckets we actually push, we can change it (I think the higher buckets, at more than 1mn are less useful) |
BrynCooke
reviewed
Feb 8, 2023
Meemaw
reviewed
Feb 9, 2023
| @@ -41,8 +42,33 @@ impl MetricsConfigurator for super::super::otlp::Config { | |||
| Some(exporter) => { | |||
| let exporter = opentelemetry_otlp::new_pipeline() | |||
| .metrics( | |||
There was a problem hiding this comment.
Might make sense to add a comment for this, as to why inexpensive() selector is not used.
BrynCooke
approved these changes
Feb 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2493
with the inexpensive selector, histogram are only reported as gauges, and so they will be incorrectly interpreted when reaching Datadog