Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add a disclaimer for users who set up health-checks and prometheus endpoints in a containers environment. #2194

Merged
merged 5 commits into from
Dec 2, 2022

Conversation

o0Ignition0o
Copy link
Contributor

Docs: Add a disclaimer for users who set up health-checks and prometheus endpoints in a containers environment.

fixes #2079

The health check and the prometheus endpoint listen to 127.0.0.1 by default. While this is a safe default, it prevents other pods from performing healthchecks and scrapping prometheus data. This behavior and customization is now documented.

…eus endpoints in a containers environment.

fixes #2079

The health check and the prometheus endpoint listen to 127.0.0.1 by default.
While this is a safe default, it prevents other pods from performing healthchecks and scrapping prometheus data.
This behavior and customization is now documented.
@github-actions

This comment has been minimized.

@o0Ignition0o o0Ignition0o marked this pull request as ready for review December 2, 2022 09:10
Copy link
Contributor

@garypen garypen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions feel free to ignore the second two.

NEXT_CHANGELOG.md Outdated Show resolved Hide resolved
docs/source/configuration/metrics.mdx Outdated Show resolved Hide resolved
docs/source/configuration/health-checks.mdx Outdated Show resolved Hide resolved
@o0Ignition0o o0Ignition0o enabled auto-merge (squash) December 2, 2022 09:25
@o0Ignition0o o0Ignition0o merged commit fda9f15 into dev Dec 2, 2022
@o0Ignition0o o0Ignition0o deleted the igni/listen_addrs_doc branch December 2, 2022 09:40
@BrynCooke BrynCooke added this to the v1.5.0 milestone Dec 3, 2022
@garypen garypen added this to the v1.5.0 milestone Dec 5, 2022
@BrynCooke BrynCooke modified the milestone: v1.5.0 Dec 5, 2022
@BrynCooke BrynCooke mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Healthcheck documentation
3 participants