-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a router_service #2170
Conversation
This comment has been minimized.
This comment has been minimized.
Make tests run against real network requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge amount of work. Really well done!!
Did you check the diffs of the documentation for public changes? Could you please document the result in the PR so we can see what has been added?
apollo-router-scaffold/templates/plugin/src/plugins/{{snake_name}}.rs
Outdated
Show resolved
Hide resolved
Here's a list of API changes: https://gist.github.com/BrynCooke/590941cc0008dabd40703aca3e9b4e6b |
@BrynCooke thanks a lot for the diff
this looks good doesn't it? do we see things that went public and shouldnt ? |
Fixes #1496 eventually.
todo:
impl TryFrom<supergraph::Request> for Request
should put the graphql::Request in the body if the method is POST, and urlencode it in the path if the method is GETfrom_supergraph_mock_callback_and_configuration
and the likes, let's maybe use a builder