Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing ca-certificates docker image #2146

Closed
wants to merge 3 commits into from
Closed

fix: missing ca-certificates docker image #2146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca470bd
fix: docker image ca-certificates
eole1712 Nov 23, 2022
db96ff4
add changelog
eole1712 Nov 23, 2022
0d2e8d5
Merge branch 'dev' into fix/ca-certificates
eole1712 Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions NEXT_CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,12 @@ By [@garypen](https://github.com/garypen) in https://github.com/apollographql/ro

## 🐛 Fixes

### ca-certificates issue on the 1.4.0 version's docker image ([Issue #2145](https://github.com/apollographql/router/issues/2145))

A regression has been fixed which caused the router to panic when running on Uplink mode from the docker image

By [@eole1712](https://github.com/eole1712) in https://github.com/apollographql/router/pull/2146

### Improve errors when subgraph returns non-GraphQL response with a non-2xx status code ([Issue #2117](https://github.com/apollographql/router/issues/2117))

The error response will now contain the status code and status name. Example: `HTTP fetch failed from 'my-service': 401 Unauthorized`
Expand Down
4 changes: 3 additions & 1 deletion dockerfiles/diy/dockerfiles/Dockerfile.repo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ WORKDIR /usr/src/router
RUN apt-get update
RUN apt-get -y install \
npm \
nodejs
nodejs \
ca-certificates

# Add rustfmt since build requires it
RUN rustup component add rustfmt
Expand All @@ -36,6 +37,7 @@ LABEL org.opencontainers.image.source="https://github.com/apollographql/router"

# Copy in the required files from our build image
COPY --from=build --chown=root:root /dist /dist
COPY --from=build --chown=root:root /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-certificates.crt

WORKDIR /dist

Expand Down