Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide multi-arch (amd64/arm64) docker images for the router #2138

Merged
merged 7 commits into from
Nov 22, 2022

Conversation

garypen
Copy link
Contributor

@garypen garypen commented Nov 21, 2022

fixes: #1932
fixes: #2098

The next time we release docker images, they will be multi-arch.

fixes: #1932

The next time we release docker images, they will be multi-arch.
@garypen garypen self-assigned this Nov 21, 2022
@github-actions

This comment has been minimized.

Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. One question, one CL suggestion.

NEXT_CHANGELOG.md Outdated Show resolved Hide resolved
@abernix abernix modified the milestones: v1-NEXT, v1.4.0 Nov 21, 2022
@garypen garypen merged commit 5412cd9 into dev Nov 22, 2022
@garypen garypen deleted the garypen/1932-multi-arch-docker branch November 22, 2022 10:44
goto-bus-stop pushed a commit that referenced this pull request Nov 29, 2022
fixes: #1932
fixes: #2098 

The next time we release docker images, they will be multi-arch.

Co-authored-by: Jesse Rosenberger <[email protected]>
garypen added a commit that referenced this pull request Nov 30, 2022
fixes: #1932
fixes: #2098 

The next time we release docker images, they will be multi-arch.

Co-authored-by: Jesse Rosenberger <[email protected]>
@BrynCooke BrynCooke added this to the v1.5.0 milestone Dec 3, 2022
@garypen garypen added this to the v1.5.0 milestone Dec 5, 2022
@BrynCooke BrynCooke modified the milestone: v1.5.0 Dec 5, 2022
@BrynCooke BrynCooke mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

M1: --hot-reload flag will not work with a process executing via rosetta 2 ARM Compatible Docker Image
4 participants