Fix naming inconsistency of telemetry.metrics.common.attributes.router

[BrynCooke]

Fix naming inconsistency of telemetry.metrics.common.attributes.router (Issue #2076)

Mirroring the rest of the config router should be supergraph

telemetry:
  metrics:
    common:
      attributes:
        router: # old

becomes

telemetry:
  metrics:
    common:
      attributes:
        supergraph: # new

Configuration upgrades (Issue #2123)

Occasionally we will make changes to the Router yaml configuration format.
When starting the Router if the configuration can be upgraded it will do so automatically and display a warning:

2022-11-22T14:01:46.884897Z  WARN router configuration contains deprecated options: 

  1. telemetry.tracing.trace_config.attributes.router has been renamed to 'supergraph' for consistency

These will become errors in the future. Run `router config upgrade <path_to_router.yaml>` to see a suggested upgraded configuration.

Note: If a configuration has errors after upgrading then the configuration will not be upgraded automatically.

From the CLI users can run:

• router config upgrade <path_to_router.yaml> to output configuration that has been upgraded to match the latest config format.
• router config upgrade --diff <path_to_router.yaml> to output a diff e.g.

 telemetry:
   apollo:
     client_name_header: apollographql-client-name
   metrics:
     common:
       attributes:
-        router:
+        supergraph:
           request:
             header:
             - named: "1" # foo

There are situations where comments and whitespace are not preserved. This may be improved in future.

By @bryncooke in #2116

CLI structure changes (Issue #2123)

As the Router gains functionality the limitations of the current CLI structure are becoming apparent.

There is now a separate subcommand for config related operations:

• config
  • schema - Output the configuration schema
  • upgrade - Upgrade the configuration with optional diff support.

router --schema has been deprecated and users should move to router config schema.

[bnjjj]

I think we should still support the old way

[EverlastingBugstopper]

this looks good to me!

[EverlastingBugstopper]

one thing we might do is support stdin for file argument types. In Rover we have a type called FileDescriptorType that implements this behavior.

(usage could be rover supergraph compose --config supergraph.yaml | router -s -)

[EverlastingBugstopper]

this PR introduces -s/--supergraph for the schema. rover uses -s/--schema everywhere for schemas. however, we never refer to a supergraph schema directly in input arguments though. 🤷🏼 food for thought

[BrynCooke]

This is wrong

[BrynCooke]

-s/--supergraph has been the name forever. Unfortunately we can't align from the router side for now as we were using --schema for outputting the schema.

We should discuss maybe aligning from the rover side. Let's also check out the terminology studio uses.