Request retries for subgraph queries #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
retries require a clonable request so it is now implemented on subgraph::Request
Geal
changed the title
|
I added some configuration options, marked as experimental, so we can move forward on this and at least have some form of retries, before we settle on the policy configuration format. |
o0Ignition0o
approved these changes
Nov 23, 2022
BrynCooke
approved these changes
Nov 23, 2022
bnjjj
approved these changes
Nov 23, 2022
|
did we decide where documentation should be written for experimental features? |
|
@Geal On my side for logging and tracing I wrote the documentation in the related section. For tracing in tracing.mdx for example. And just mark it as experimental |
|
alright, there's docs now. I feel like the traffic shaping doc could benefit from longer explanations of each feature, and maybe a description of their order and interaction |
|
also, as a follow-up, I think I'll add an option on retries, to deactivate them on mutations if necessary (not all mutations are idempotent) |
Geal
added a commit
that referenced
this pull request
Nov 28, 2022
garypen
pushed a commit
that referenced
this pull request
Nov 30, 2022
implements retries for subgraph requests. This uses Finagle's retry buckets algorithm
garypen
pushed a commit
that referenced
this pull request
Nov 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #338
Fix: #1956