-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: v1.0.0-rc.1 #1810
Merged
Merged
release: v1.0.0-rc.1 #1810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
abernix
requested review from
o0Ignition0o,
bnjjj,
garypen,
BrynCooke,
Geal and
SimonSapin
September 16, 2022 13:49
bnjjj
requested changes
Sep 16, 2022
Co-authored-by: Coenen Benjamin <[email protected]>
Co-authored-by: Coenen Benjamin <[email protected]>
bnjjj
approved these changes
Sep 16, 2022
SimonSapin
approved these changes
Sep 16, 2022
o0Ignition0o
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ BREAKING ❗
Change
headers
propagation configuration (PR #1795)While it wasn't necessary today, we want to avoid a necessary breaking change in the future by proactively making room for up-and-coming work. We've therefore introduced another level into the
headers
configuration with arequest
object, to allow for aresponse
(see Issue #1284) to be an additive feature after 1.0.A rough look at this should just be a matter of adding in
request
and indenting everything that was inside it:headers: all: + request: - remove: named: "test"
The good news is that we'll have
response
in the future! For a full set of examples, please see the header propagation documentation.By @bnjjj in #1795
Bind the Sandbox on the same endpoint as the Supergraph, again (Issue #1785)
We have rolled back an addition that we released in this week's
v1.0.0-rc.0
which allowed Sandbox (an HTML page that makes requests to thesupergraph
endpoint) to be on a custom socket. In retrospect, we believe it was premature to make this change without considering the broader impact of this change which ultimately touches on CORS and some developer experiences bits. Practically speaking, we may not want to introduce this because it complicates the model in a number of ways.For the foreseeable future, Sandbox will continue to be on the same listener address as the
supergraph
listener.It's unlikely anyone has really leaned into this much already, but if you've already re-configured
sandbox
orhomepage
to be on a customlisten
-er and/orpath
in1.0.0-rc.0
, here is a diff of what you should remove:Note this means you can either enable the
homepage
, or thesandbox
, but not both.By @o0Ignition0o in #1796
🚀 Features
Automatically check "Return Query Plans from Router" checkbox in Sandbox (Issue #1803)
When loading Sandbox, we now automatically configure it to toggle the "Request query plans from Router" checkbox to the enabled position which requests query plans from the Apollo Router when executing operations. These query plans are displayed in the Sandbox interface and can be seen by selecting "Query Plan Preview" from the drop-down above the panel on the right side of the interface.
By @abernix in #1804
🐛 Fixes
Fix
--dev
mode when no configuration file is specified (Issue #1801) (Issue #1802)We've reconciled an issue where the
--dev
mode flag was being ignored when running the router without a configuration file. (While many use cases do require a configuration file, the Router actually doesn't need a confguration in many cases!)By @bnjjj in #1808
Respect
supergraph
'spath
for Kubernetes deployment probes (Issue #1787)If you've configured the
supergraph
'spath
property using the Helm chart, the livenessand readiness probes now utilize these correctly. This fixes a bug where they continued to use the default path of
/
and resulted in a startup failure.By @damienpontifex in #1788
Get variable default values from the query for query plan condition nodes (PR #1640)
The query plan condition nodes, generated by the
if
argument of the@defer
directive, werenot using the default value of the variable passed in as an argument.
This also fixes default value validations for non-
@defer
'd queries.By @Geal in #1640
Correctly hot-reload when changing the
supergraph
'slisten
socket (Issue #1814)If you change the
supergraph
'slisten
socket while in--hot-reload
mode, the Router will now correctly pickup the change and bind to the new socket.By @o0Ignition0o in #1815
🛠 Maintenance
Improve error message when querying non existent field Issue #1816
When querying a non-existent field you will get a better error message:
By @bnjjj in #1817
Update
apollo-router-scaffold
to use the publishedapollo-router
crate PR #1782Now that
apollo-router
is released on crates.io, we have updated the project scaffold to rely on the published crate instead of Git tags.By @o0Ignition0o in #1782
Refactor
Configuration
validation Issue #1791Instantiating
Configuration
s is now fallible, because it will run consistency checks on top of the already run structure checks.By @o0Ignition0o in #1794
Refactor response-formatting tests #1798
Rewrite the response-formatting tests to use a builder pattern instead of macros and move the tests to a separate file.
By @Geal in #1798
📚 Documentation
Add
rustdoc
documentation to various modules (Issue #799)Adds documentation for:
apollo-router/src/layers/instrument.rs
apollo-router/src/layers/map_first_graphql_response.rs
apollo-router/src/layers/map_future_with_request_data.rs
apollo-router/src/layers/sync_checkpoint.rs
apollo-router/src/plugin/serde.rs
apollo-router/src/tracer.rs
By @garypen in #1792
Fixed
docs.rs
publishing error from our last releaseDuring our last release we discovered for the first time that our documentation wasn't able to compile on the docs.rs website, leaving our documentation in a failed state.
While we've reconciled that particular problem, we're now being affected by this internal compiler errors (ICE) that is affecting anyone using
1.65.0-nightly
builds circa today. Since docs.rs usesnightly
for all builds, this means it'll be a few more days before we're published there.With thanks to @SimonSapin in apollographql/federation-rs#185