Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect supergraph path for kubernetes deployment probes #1788

Merged
merged 3 commits into from
Sep 15, 2022
Merged

Respect supergraph path for kubernetes deployment probes #1788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61e53c1
Respect supergraphpath for kubernetes deployment probes
damienpontifex Sep 15, 2022
380b12d
next changelog
damienpontifex Sep 15, 2022
290aed7
Merge branch 'main' into probe-supergraph-path
garypen Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions NEXT_CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,14 @@ By [@USERNAME](https://github.com/USERNAME) in https://github.com/apollographql/
## ❗ BREAKING ❗
## 🚀 Features
## 🐛 Fixes

### Respect supergraph path for kubernetes deployment probes (#1787)

For cases where you configured the `supergraph.path` for the router when using the helm chart, the liveness
and readiness probes continued to use the default path of `/` and so the start failed.

By @damienpontifex in #1788


## 🛠 Maintenance
## 📚 Documentation
4 changes: 2 additions & 2 deletions helm/chart/router/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,14 +92,14 @@ spec:
httpHeaders:
- name: Content-Type
value: application/json
path: "/?query={__typename}"
path: {{ .Values.router.configuration.supergraph.path | default "/" }}?query={__typename}
port: {{ .Values.containerPorts.http }}
readinessProbe:
httpGet:
httpHeaders:
- name: Content-Type
value: application/json
path: "/?query={__typename}"
path: {{ .Values.router.configuration.supergraph.path | default "/" }}?query={__typename}
port: {{ .Values.containerPorts.http }}
resources:
{{- toYaml .Values.resources | nindent 12 }}
Expand Down