more cleanup following removal of ServiceBuilderExt::cache #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr: #1535 removed ServiceBuilderExt::cache. That means there are no consumers for the cache layer functionality. This PR removes that layer and means we can also remove our dependency on moka. I've also removed the dependendy on `include_dir` which is no longer in use. Should save some compilation time and improve our security footprint (less crates).
This comment has been minimized.
This comment has been minimized.
for the change.
o0Ignition0o
approved these changes
Aug 30, 2022
Geal
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr: #1535 removed ServiceBuilderExt::cache.
That means there are no consumers for the cache layer functionality.
This PR removes that layer and means we can also remove our dependency
on moka. I've also removed the dependendy on
include_dirwhich is nolonger in use.
Should save some compilation time and improve our security footprint
(less crates).