Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger perf test from github. #58

Closed
BrynCooke opened this issue Aug 25, 2021 · 2 comments
Closed

Trigger perf test from github. #58

BrynCooke opened this issue Aug 25, 2021 · 2 comments
Assignees
@BrynCooke

Comments

@BrynCooke
Copy link
Contributor

PRs should auto run perf tests
@BrynCooke BrynCooke self-assigned this Aug 25, 2021
@abernix
Copy link
Member

abernix commented Aug 26, 2021

Possibly some inspiration, but not a solution: https://github.com/marketplace/actions/continuous-benchmark

@o0Ignition0o o0Ignition0o transferred this issue from another repository Nov 4, 2021
@abernix abernix mentioned this issue Dec 3, 2021
Closed
@abernix abernix added 2021-12 and removed 2021-11 labels Dec 3, 2021
@abernix
Copy link
Member

abernix commented Jan 5, 2022

Done via several pull requests.

@abernix abernix closed this as completed Jan 5, 2022
tinnou pushed a commit to Netflix-Skunkworks/router that referenced this issue Oct 16, 2023
@o0Ignition0o
chore: Make harmonizer snapshots (apollographql#58)
50067f5 
Fixes apollographql#44

deno_core advocates for us to use snapshots instead of loading scripts and running them.
One of the recent side effects is that deno_core prints `rerun-if-changed` directives when loading scripts manually.

This commit moves the scripts loading mechanism to the build (in `build_harmonizer.rs`) so the messages mentioned above won't display at runtime.
tinnou pushed a commit to Netflix-Skunkworks/router that referenced this issue Oct 16, 2023
@o0Ignition0o
fix: generate deno snapshots in build.rs (apollographql#65)
ae16a4e 
In apollographql#58 I added a snapshots generation phase to our harmonizer packages.

However I created a bug because the snapshot generation phase would happen when the harmonizer-0 and harmonizer-2 packages are generated.

This means downstream users who would rely on published harmonizer crates would get snapshots generated by an other computer / architecture.

This triggered a bug that would fail any harmonizer call when relying on the published crate.

This commit adds a build.rs script to the published crates, so that snapshots are created when downstream binaries are built.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrynCooke BrynCooke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BrynCooke @abernix @o0Ignition0o