Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make router service call failed a more specific/helpful error #4899

Closed
andrewmcgivery opened this issue Apr 3, 2024 · 0 comments · Fixed by #4900
Closed

Make router service call failed a more specific/helpful error #4899

andrewmcgivery opened this issue Apr 3, 2024 · 0 comments · Fixed by #4900
Assignees
@garypen
Labels
raised by user

Comments

@andrewmcgivery
Copy link
Contributor

Describe the solution you'd like
Router currently throws the error router service call failed when major something goes wrong. The instances I've seen it in are when a coprocessor is broken or not deployed. The error in it's current form is unhelpful and would be nice if it tried to specify what went wrong (some kind of more specific error).

Currently thrown from two places in the code:

https://github.com/apollographql/router/blob/dev/apollo-router/src/axum_factory/axum_http_server_factory.rs#L650
https://github.com/apollographql/router/blob/dev/apollo-router/src/axum_factory/axum_http_server_factory.rs#L683
@garypen garypen self-assigned this Apr 3, 2024
garypen added a commit that referenced this issue Apr 3, 2024
@garypen
add error details to 'router service call failed'
10cf769 
It can be difficult to understand 'router service call failed' messages.
Adding the error detail should make them more comprehensible.

fixes: #4899
@garypen garypen mentioned this issue Apr 3, 2024
Merged
garypen added a commit that referenced this issue Apr 4, 2024
@garypen
add error details to 'router service call failed' (#4900)
114825d 
It can be difficult to understand 'router service call failed' messages.
Adding the error detail should make them more comprehensible.

fixes: #4899
@o0Ignition0o o0Ignition0o mentioned this issue Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garypen garypen

Labels
raised by user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add error details to 'router service call failed' apollographql/router
2 participants
@garypen @andrewmcgivery