Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom events defined by yaml #4320

Closed
Tracked by #3226
BrynCooke opened this issue Dec 4, 2023 · 0 comments · Fixed by #4956
Closed
Tracked by #3226

Custom events defined by yaml #4320

BrynCooke opened this issue Dec 4, 2023 · 0 comments · Fixed by #4956
Assignees
@bnjjj
Labels
component/logging component/open-telemetry OTLP, Datadog, Prometheus, etc. and the integrations around it.

Comments

@BrynCooke
Copy link
Contributor

BrynCooke commented Dec 4, 2023 •
edited
Loading

Allow users to configure events via yaml as documented in https://www.apollographql.com/docs/router/configuration/telemetry/instrumentation/events
This will allow users to avoid reaching for rhai or a custom plugin when they want to log that something has happened e.g. a request had errors of a particular type.
@BrynCooke BrynCooke mentioned this issue Dec 4, 2023
Open
28 tasks
@BrynCooke BrynCooke mentioned this issue Jan 11, 2024
Open
@bnjjj bnjjj added component/open-telemetry OTLP, Datadog, Prometheus, etc. and the integrations around it. component/logging labels Jan 24, 2024
@BrynCooke BrynCooke mentioned this issue Feb 1, 2024
Closed
@bnjjj bnjjj self-assigned this Apr 2, 2024
@bnjjj bnjjj mentioned this issue Apr 15, 2024
Merged
6 tasks
BrynCooke pushed a commit that referenced this issue Apr 22, 2024
@bnjjj
feat(telemetry): add support of custom events in telemetry (#4956)
2f1ef5d 
Fixes #4320

---

**Checklist**

Complete the checklist (and note appropriate exceptions) before the PR
is marked ready-for-review.

- [x] Changes are compatible[^1]
- [x] Documentation[^2] completed
- [ ] Performance impact assessed and acceptable
- Tests added and passing[^3]
    - [x] Unit Tests
    - [x] Integration Tests
    - [x] Manual Tests

**Exceptions**

*Note any exceptions here*

**Notes**

[^1]: It may be appropriate to bring upcoming changes to the attention
of other (impacted) groups. Please endeavour to do this before seeking
PR approval. The mechanism for doing this will vary considerably, so use
your judgement as to how and when to do this.
[^2]: Configuration is an important part of many changes. Where
applicable please try to document configuration examples.
[^3]: Tick whichever testing boxes are applicable. If you are adding
Manual Tests, please document the manual testing (extensively) in the
Exceptions.

---------

Signed-off-by: Benjamin Coenen <[email protected]>
@shorgi shorgi mentioned this issue Apr 22, 2024
Merged
bnjjj pushed a commit that referenced this issue Apr 23, 2024
@shorgi
docs: custom events telemetry (#5001)
8d39abf 
Docs for #4320 (PR
#4956):

- Unhide Events page and add to left-nav
- Add telemetry performance trade-off note
@abernix abernix reopened this Apr 24, 2024
@abernix abernix closed this as completed Apr 24, 2024
@BrynCooke BrynCooke mentioned this issue May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bnjjj bnjjj

Labels
component/logging component/open-telemetry OTLP, Datadog, Prometheus, etc. and the integrations around it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(telemetry): add support of custom events in telemetry apollographql/router
3 participants
@BrynCooke @abernix @bnjjj