Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ordering of batch responses #4143

Closed
garypen opened this issue Nov 4, 2023 · 0 comments · Fixed by #4144
Closed

fix ordering of batch responses #4143

garypen opened this issue Nov 4, 2023 · 0 comments · Fixed by #4144
Assignees
@garypen

Comments

@garypen
Copy link
Contributor

garypen commented Nov 4, 2023

If a batch of requests is received and processed then the response to the final request is returned first.

i.e.:

Request   Response
   a          c
   b          a
   c          b

Ordering should be preserved since the client expects to get responses back in the same order
@garypen garypen self-assigned this Nov 4, 2023
@garypen garypen mentioned this issue Nov 4, 2023
Merged
6 tasks
garypen added a commit that referenced this issue Nov 9, 2023
@garypen
Remove the first element from the Vec, not the last (#4144)
2416322 
This addresses the bug found in-house testing of experimental batching
support.

Fixes #4143

<!-- start metadata -->
---

**Checklist**

Complete the checklist (and note appropriate exceptions) before the PR
is marked ready-for-review.

- [ ] Changes are compatible[^1]
- [ ] Documentation[^2] completed
- [ ] Performance impact assessed and acceptable
- Tests added and passing[^3]
    - [ ] Unit Tests
    - [ ] Integration Tests
    - [ ] Manual Tests

**Exceptions**

*Note any exceptions here*

**Notes**

[^1]: It may be appropriate to bring upcoming changes to the attention
of other (impacted) groups. Please endeavour to do this before seeking
PR approval. The mechanism for doing this will vary considerably, so use
your judgement as to how and when to do this.
[^2]: Configuration is an important part of many changes. Where
applicable please try to document configuration examples.
[^3]: Tick whichever testing boxes are applicable. If you are adding
Manual Tests, please document the manual testing (extensively) in the
Exceptions.
@abernix abernix mentioned this issue Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garypen garypen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the first element from the Vec, not the last apollographql/router
1 participant
@garypen