Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authorization: more error configuration #4116

Closed
Geal opened this issue Oct 30, 2023 · 0 comments · Fixed by #4122
Closed

Authorization: more error configuration #4116

Geal opened this issue Oct 30, 2023 · 0 comments · Fixed by #4122
Assignees
@Geal
Labels
component/auth

Comments

@Geal
Copy link
Contributor

Geal commented Oct 30, 2023

follow up to #4076 and #4079

the dry-run option is supposed to ease migration, but the default behaviour of clients is to raise an exception on errors, so that would still make it a huge step. We could instead make that step easier with more configurable errors. #4076 gives the ability to remove errors from logs. But we could also have the following modes:

  • put errors in the response's extensions field so it would not raise exceptions
  • log errors but do not return them with the response
@Geal Geal mentioned this issue Oct 30, 2023
Merged
6 tasks
@Geal Geal self-assigned this Oct 31, 2023
@Geal Geal mentioned this issue Oct 31, 2023
Merged
6 tasks
@Geal Geal closed this as completed in #4122 Nov 2, 2023
Geal added a commit that referenced this issue Nov 2, 2023
@Geal @garypen
configurable error location (#4122)
3ad7856 
Fix #4116

This makes authorization errors reporting more flexible, by configuring
response errors in one of two ways:
- authorization errors in the errors fields
- authorization errors in the extensions fields
- not returning errors to the client

This will work nicely with the dry-run option, allowing a test of
authorization that will not trigger exceptions in the client (due to the
`errors` field), and so an easier integration path.

Co-authored-by: Gary Pennington <[email protected]>
@goto-bus-stop goto-bus-stop mentioned this issue Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Geal Geal

Labels
component/auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

configurable error location apollographql/router
1 participant
@Geal