Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apollo-router/src/uplink/license_stream.rs #4110

Closed
Tracked by #4103
garypen opened this issue Oct 27, 2023 · 0 comments · Fixed by #4111
Closed
Tracked by #4103

apollo-router/src/uplink/license_stream.rs #4110

garypen opened this issue Oct 27, 2023 · 0 comments · Fixed by #4111
Assignees
@garypen

Comments

@garypen
Copy link
Contributor

garypen commented Oct 27, 2023

No description provided.

This was referenced Oct 27, 2023
Closed
Merged
garypen added a commit that referenced this issue Nov 10, 2023
@garypen
Ensure that license_stream and files bounded channels are bounded (#4111
bcaf2ad 
)

Convert `futures` channels to `tokio` channels.

Fixes #4109
Fixes #4110 

<!-- start metadata -->
---

**Checklist**

Complete the checklist (and note appropriate exceptions) before the PR
is marked ready-for-review.

- [x] Changes are compatible[^1]
- [x] Documentation[^2] completed
- [x] Performance impact assessed and acceptable
- Tests added and passing[^3]
    - [ ] Unit Tests
    - [ ] Integration Tests
    - [ ] Manual Tests

**Exceptions**

*Note any exceptions here*

**Notes**

[^1]: It may be appropriate to bring upcoming changes to the attention
of other (impacted) groups. Please endeavour to do this before seeking
PR approval. The mechanism for doing this will vary considerably, so use
your judgement as to how and when to do this.
[^2]: Configuration is an important part of many changes. Where
applicable please try to document configuration examples.
[^3]: Tick whichever testing boxes are applicable. If you are adding
Manual Tests, please document the manual testing (extensively) in the
Exceptions.
@abernix abernix mentioned this issue Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garypen garypen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure that license_stream and files bounded channels are bounded apollographql/router
1 participant
@garypen