telemetry should happen first #3915
Assignees
Comments
BrynCooke
pushed a commit
that referenced
this issue
Sep 27, 2023
…a throwback from when the router service did not exist. Move operation count metrics to the first thing that happens in the pipeline. Note that this won't catch disconnects because they are reliant on the status code of the response, which will stop processing before the metric is incremented. Fixes #3915
6 tasks
BrynCooke
pushed a commit
that referenced
this issue
Sep 27, 2023
Our metrics are currently mutated at the supergraph service. This is a throwback from when the router service did not exist. Move operation count metrics to the first thing that happens in the pipeline. Note that this won't catch disconnects because they are reliant on the status code of the response, which will stop processing before the metric is incremented. Fixes #3915
BrynCooke
added a commit
that referenced
this issue
Sep 27, 2023
…line. (#3919) Our metrics are currently mutated at the supergraph service. This is a throwback from when the router service did not exist. Move operation count metrics to the first thing that happens in the pipeline. Note that this won't catch disconnects because they are reliant on the status code of the response, which will stop processing before the metric is incremented. This also move the creation of the root span to the just after so that cors and extensions are traced. Fixes #3915 <!-- start metadata --> --- **Checklist** Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review. - [ ] Changes are compatible[^1] - [ ] Documentation[^2] completed - [ ] Performance impact assessed and acceptable - Tests added and passing[^3] - [ ] Unit Tests - [ ] Integration Tests - [ ] Manual Tests **Exceptions** *Note any exceptions here* **Notes** [^1]: It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]: Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]: Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. --------- Co-authored-by: bryn <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As the router pipeline has evolved various things have crept in before the telemetry plugin. This means that we may be inaccurate operation counts and spans will be missing some processing time.
apollo.router.operationsmetric should be moved to the fist thing in the pipeline in factory.In addition, the make span layer should also move.
The text was updated successfully, but these errors were encountered: