Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build_docker_image.sh script was broken by the introduction of cmake as a build dependency #3823

Closed
garypen opened this issue Sep 14, 2023 · 0 comments · Fixed by #3824
Closed

build_docker_image.sh script was broken by the introduction of cmake as a build dependency #3823

garypen opened this issue Sep 14, 2023 · 0 comments · Fixed by #3824
Assignees
@garypen

Comments

@garypen
Copy link
Contributor

garypen commented Sep 14, 2023

Changes required to update deno were made to our build requirements in: #3626.

In particular, this now requires cmake to be available during a router build.

This has broken the diy build_docker_image.sh script.
@garypen garypen self-assigned this Sep 14, 2023
@garypen garypen mentioned this issue Sep 14, 2023
Merged
1 task
garypen added a commit that referenced this issue Sep 14, 2023
@garypen
fix the diy build_docker_image.sh script (#3824)
9b618d0 
Required to build deno.

Fixes #3823 

<!-- start metadata -->
---

**Checklist**

Complete the checklist (and note appropriate exceptions) before the PR
is marked ready-for-review.

- [x] Changes are compatible[^1]

**Exceptions**

*Note any exceptions here*

**Notes**

[^1]: It may be appropriate to bring upcoming changes to the attention
of other (impacted) groups. Please endeavour to do this before seeking
PR approval. The mechanism for doing this will vary considerably, so use
your judgement as to how and when to do this.
[^2]: Configuration is an important part of many changes. Where
applicable please try to document configuration examples.
[^3]: Tick whichever testing boxes are applicable. If you are adding
Manual Tests, please document the manual testing (extensively) in the
Exceptions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garypen garypen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix the diy build_docker_image.sh script apollographql/router
1 participant
@garypen