Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure to parse schema does not output any information on where the parse failure occured #3681

Closed
BrynCooke opened this issue Aug 25, 2023 · 1 comment · Fixed by #3674
Closed

Failure to parse schema does not output any information on where the parse failure occured #3681

BrynCooke opened this issue Aug 25, 2023 · 1 comment · Fixed by #3674
Assignees
@goto-bus-stop
Labels
story/ux Workflows impacting the user experience.

Comments

@BrynCooke
Copy link
Contributor

Related to #3680

The only output is ERROR could not create router: GraphQL parser error(s).
@abernix abernix added the story/ux Workflows impacting the user experience. label Aug 28, 2023
goto-bus-stop added a commit that referenced this issue Sep 7, 2023
@goto-bus-stop
Remove ValidationErrors::print
6f1a997 
Schema parse errors do get bubbled up (though they get obscured by #3681)
goto-bus-stop added a commit that referenced this issue Sep 7, 2023
@goto-bus-stop
Extend error message for parse/validation errors on startup, fixes #3681
525f376
@goto-bus-stop goto-bus-stop mentioned this issue Sep 7, 2023
Merged
3 tasks
@goto-bus-stop goto-bus-stop self-assigned this Sep 8, 2023
@goto-bus-stop
Copy link
Member

#3674 adds location info and error message. It's not that pretty but that will improve as apollo-rs's plain-string messages get more detailed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goto-bus-stop goto-bus-stop

Labels
story/ux Workflows impacting the user experience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add logs and extend metrics for graphql_validation_mode: both apollographql/router
3 participants
@BrynCooke @abernix @goto-bus-stop