-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loglevel Trace causes Router to crash #3474
Labels
Comments
It looks like the error is in the
This will give trace logging for all crates apart from |
garypen
added a commit
that referenced
this issue
Jul 20, 2023
It would be nice if users could specify just a log level and the router applied the required filtering to constrain the logging to the `apollo_router` module. It would also be nice if, for advanced users, you could exercise the full power of a logging filter. This PR enables both these use cases. If you set a filter using `RUST_LOG`, it is used as is. If you set it using `APOLLO_ROUTER_LOG` or `--log`, then any "global" scope levels are constrained to `apollo_router`. Thus: ``` RUST_LOG=apollo_router=warn --log warn APOLLO_ROUTER_LOG=warn ``` are equivalent with all three statements resulting in `warn` level logging for the router. For more details, read the logging configuration documentation. fixes: #3474
6 tasks
garypen
added a commit
that referenced
this issue
Jul 21, 2023
) It would be nice if users could specify just a log level and the router applied the required filtering to constrain the logging to the `apollo_router` module. It would also be nice if, for advanced users, you could exercise the full power of a logging filter. This PR enables both these use cases. If you set a filter using `RUST_LOG`, it is used as is. If you set it using `APOLLO_ROUTER_LOG` or `--log`, then any "global" scope levels are constrained to `apollo_router`. Thus: ``` RUST_LOG=apollo_router=warn --log warn APOLLO_ROUTER_LOG=warn ``` are equivalent with all three statements resulting in `warn` level logging for the router. For more details, read the logging configuration documentation. fixes: #3474 <!-- start metadata --> **Checklist** Complete the checklist (and note appropriate exceptions) before a final PR is raised. - [ ] Changes are compatible[^1] - [x] Documentation[^2] completed - [ ] Performance impact assessed and acceptable - Tests added and passing[^3] - [x] Unit Tests - [ ] Integration Tests - [ ] Manual Tests **Exceptions** *Note any exceptions here* **Notes** [^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests: - please document the manual testing (extensively) in the Exceptions. - please raise a separate issue to automate the test and label it (or ask for it to be labeled) as `manual test` --------- Co-authored-by: Bryn Cooke <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Reporting on behalf of a customer. They're reporting these issues (whenever loglevel is set to
trace
):trace
, the Router will crash after some time, or potentially immediatelyTo Reproduce
Use this config:
Start the router with
./router --config router.yaml --log=trace
and it should crash.Expected behavior
Router to not crash.
Output
Last log before crashing over time (TLS only):
Last logs before crashing on start (JWT + TLS)
Desktop (please complete the following information):
Additional context
The affected user also has been experiencing the issue noted in #3124, which may or may not be related. I (personally) have been unable to reproduce either issue, however.
The text was updated successfully, but these errors were encountered: