Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a builder for router::Request #3267

Closed
Geal opened this issue Jun 16, 2023 · 0 comments · Fixed by #3430
Closed

Add a builder for router::Request #3267

Geal opened this issue Jun 16, 2023 · 0 comments · Fixed by #3430
Assignees
@Geal

Comments

@Geal
Copy link
Contributor

Geal commented Jun 16, 2023 •
edited
Loading

The struct is marked as non-exhaustive, so if a router plugin tries to destructure it and reconstruct it, it cannot because the struct syntax is not available for non exhaustive types:

router/apollo-router/src/services/router.rs

Lines 38 to 45 in 6553e35

#[non_exhaustive]
pub struct Request {
/// Original request to the Router.
pub router_request: http::Request<Body>,
/// Context for extension
pub context: Context,
}

@Geal Geal mentioned this issue Jul 13, 2023
Merged
6 tasks
@Geal Geal self-assigned this Jul 13, 2023
Geal added a commit that referenced this issue Oct 19, 2023
@Geal
add a router request builder (#3430)
4c8805a 
Fix #3267 

The builder implementation was missing on the router request side, which
means that router service level plugins cannot reuse the context if they
unpack the request object
@goto-bus-stop goto-bus-stop mentioned this issue Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Geal Geal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add a router request builder apollographql/router
1 participant
@Geal